Dukascopy Support Board • View topic

jacques3901

Hi,

I use "order.setOpenPrice(OpenPrice)" to modify a pending ticket's opened price. It works in history strategy tester. But when I try to run in opened market, the pending ticket's opened price cannot be modified without any error information output.Below is my script:

if(order.getState() ==IOrder.State.OPENED){
if(order.getOpenPrice() !=BuyStop){
order.setOpenPrice(BuyStop);
}
}

Please help check what's wrong in my script.

Thanks!

API Support

jacques3901 wrote:

the pending ticket's opened price cannot be modified without any error information output

Please elaborate what messages you get. Please provide an example strategy which replicates this.

hyperscalper

jacques3901 wrote:

Hi,

I use "order.setOpenPrice(OpenPrice)" to modify a pending ticket's opened price. It works in history strategy tester. But when I try to run in opened market, the pending ticket's opened price cannot be modified without any error information output.Below is my script:

if(order.getState() ==IOrder.State.OPENED){
if(order.getOpenPrice() !=BuyStop){
order.setOpenPrice(BuyStop);
}
}

Please help check what's wrong in my script.

Thanks!

You should check for an exception on the order.setOpenPrice(...)

This could possibly be relevant, but your code may be OK as well.
I always use the "equals" method for enumerated values like IOrder.State.OPENED
That re-write would be like this:

                if(order.getState().equals(IOrder.State.OPENED)) { // using .equals
                    if(order.getOpenPrice() !=BuyStop){
                             try {
                                        order.setOpenPrice(BuyStop);
                             }
                             catch(Exception e) {
                                        e.printStackTrace();
                             }
                    }
                }

Hope this helps !!
HyperScalper

API Support

hyperscalper wrote:

This could possibly be relevant, but your code may be OK as well.
I always use the "equals" method for enumerated values like IOrder.State.OPENED
That re-write would be like this:

Actually using == or Object.equals for enums is effectively the same, have a look at the java.lang.Enum.equals implementation.

jacques3901

hyperscalper wrote:

jacques3901 wrote:

Hi,

I use "order.setOpenPrice(OpenPrice)" to modify a pending ticket's opened price. It works in history strategy tester. But when I try to run in opened market, the pending ticket's opened price cannot be modified without any error information output.Below is my script:

if(order.getState() ==IOrder.State.OPENED){
if(order.getOpenPrice() !=BuyStop){
order.setOpenPrice(BuyStop);
}
}

Please help check what's wrong in my script.

Thanks!

You should check for an exception on the order.setOpenPrice(...)

This could possibly be relevant, but your code may be OK as well.
I always use the "equals" method for enumerated values like IOrder.State.OPENED
That re-write would be like this:

                if(order.getState().equals(IOrder.State.OPENED)) { // using .equals
                    if(order.getOpenPrice() !=BuyStop){
                             try {
                                        order.setOpenPrice(BuyStop);
                             }
                             catch(Exception e) {
                                        e.printStackTrace();
                             }
                    }
                }

Hope this helps !!
HyperScalper

Thanks for your perfect clues. After check through scrip body, I found there are another condition as below:

if(order.getComment()=="STAT1")

I changed the script as your suggestion to:
if(order.getComment().equals("STAT1"))

it works!

Thank you very much.

Strangely, why my orginally script can work in historical tester?

API Support

jacques3901 wrote:

order.getOpenPrice() !=BuyStop

This is error-prone, use Double.compare, i.e.,

Double.compare(order.getOpenPrice(),BuyStop)!=0

hyperscalper

Also don't forget that some changes to a given order's properties, and
certainly successive order operations MUST be paced to allow a MINIMUM of
1 second between successive operations, on a particular order.

So you may be able to change 100 order's prices all within 1 second, but you can't change
a SPECIFIC order's price more often than once PER second...

Otherwise, an exception will be thrown, so anticipate that possibility.

If a Strategy method throws an uncaught exception, your Strategy may
be terminated, so always handle exceptions properly within each IStrategy
method to prevent this from happening.

HyperScalper