hello, i am trying to convert code form mq4 to java, it converts succesfully and compiles but then errors show up when you use it, this is probably because i have no idea into programming.
Can someone help me make this indicator work, here is the code in mq4
//+------------------------------------------------------------------+
//| Detrended Price Oscillator.mq4 |
//| Copyright © 2008, Nievinny |
//| https://www.viixtrader.com |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2008, Nievinny"
#property link "https://www.viixtrader.com"
#property indicator_separate_window
#property indicator_buffers 1
#property indicator_color1 Black
//---- input parameters
extern string ____0____ = "Period of average";
extern int DPOPeriod = 7;
extern string ____1____ = "Type of average: SMA - 0, EMA - 1, SMMA - 2, LWMA - 3";
extern int MaType = 0;
extern string ____2____ = "Type of price: close - 0, open - 1, high - 2, low - 3";
extern int PriceType = 0;
extern string ____3____ = "Moving Average Shift";
extern int MaShift = 0;
extern string ____4____ = "Show oversold and overbought levels";
extern bool ShowLevels = true;
extern string ____5____ = "Lines color (60%)";
extern color LinesColor1 = Green;
extern string ____6____ = "Lines color (100%)";
extern color LinesColor2 = Green;
extern string ____7____ = "Lines style: solid - 0, dashed - 1, dotted - 2";
extern int LinesStyle = 2;
//---- buffers
double ExtMapBuffer1[];
int init()
{
SetIndexStyle(0,DRAW_LINE);
SetIndexBuffer(0,ExtMapBuffer1);
string Short="DPO("+DPOPeriod+", "+MaType+", "+PriceType+", "+MaShift+")";
IndicatorShortName(Short);
SetIndexLabel(0,Short);
SetLevelValue(0, 0.0);
SetIndexDrawBegin(0,DPOPeriod);
return(0);
}
int deinit()
{
// cleaning the mess
if(ShowLevels == true)
{
ObjectDelete("dev1");
ObjectDelete("dev2");
ObjectDelete("dev3");
ObjectDelete("dev4");
}
return(0);
}
int start()
{
//main core
int i, counted_bars=IndicatorCounted();
if(Bars<=DPOPeriod) return(0);
if(counted_bars<1)
for(i=1;i<=DPOPeriod;i++) ExtMapBuffer1[Bars-i]=0.0;
i=Bars-DPOPeriod-1;
if(counted_bars>=DPOPeriod) i=Bars-counted_bars-1;
while(i>=0)
{
ExtMapBuffer1[i] = priceSwitch(i) - iMA(NULL, NULL, DPOPeriod, MaShift, MaType, PriceType, i);
i--;
}
// Showing oversold/overbought levels
if(ShowLevels == true)
{
int window = WindowFind("DPO("+DPOPeriod+", "+MaType+", "+PriceType+", "+MaShift+")");
if(window == -1)
{
window = 1;
}
// counting stddev
ArraySetAsSeries(ExtMapBuffer1, true);
double dev = iStdDevOnArray(ExtMapBuffer1, Bars-counted_bars-1, 100,0,0,0);
// lines creation
ObjectCreate("dev1", OBJ_HLINE, window, TimeCurrent(), 1.2*dev);
ObjectSetText("dev1", "+60%");
ObjectSet("dev1", OBJPROP_COLOR, LinesColor1);
ObjectSet("dev1", OBJPROP_STYLE, LinesStyle);
ObjectCreate("dev2", OBJ_HLINE, window, TimeCurrent(), -1.8*dev);
ObjectSetText("dev2", "-60%");
ObjectSet("dev2", OBJPROP_COLOR, LinesColor1);
ObjectSet("dev2", OBJPROP_STYLE, LinesStyle);
ObjectCreate("dev3", OBJ_HLINE, window, TimeCurrent(), 2*dev);
ObjectSetText("dev3", "+100%");
ObjectSet("dev3", OBJPROP_COLOR, LinesColor2);
ObjectSet("dev3", OBJPROP_STYLE, LinesStyle);
ObjectCreate("dev4", OBJ_HLINE, window, TimeCurrent(), -3*dev);
ObjectSetText("dev4", "-100%");
ObjectSet("dev4", OBJPROP_COLOR, LinesColor2);
ObjectSet("dev4", OBJPROP_STYLE, LinesStyle);
}
return(0);
}
double priceSwitch(int i)
{
double price;
switch(PriceType)
{
case PRICE_CLOSE:
price = Close[i];
case PRICE_OPEN:
price = Open[i];
case PRICE_HIGH:
price = High[i];
case PRICE_LOW:
price = Low[i];
}
return(price);
}
here is another simpler version
//+------------------------------------------------------------------+
//| Detrended Price Oscillator.mq4 |
//| Ramdass - Conversion only |
//+------------------------------------------------------------------+
#property indicator_separate_window
#property indicator_buffers 1
#property indicator_color1 DodgerBlue
//----
extern int x_prd = 14;
extern int CountBars = 300;
//---- buffers
double dpo[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
string short_name;
//---- indicator line
SetIndexStyle(0, DRAW_LINE);
SetIndexBuffer(0, dpo);
//---- name for DataWindow and indicator subwindow label
short_name = "DPO(" + x_prd + ")";
IndicatorShortName(short_name);
SetIndexLabel(0, short_name);
//----
if(CountBars >= Bars)
CountBars = Bars;
SetIndexDrawBegin(0, Bars - CountBars + x_prd + 1);
//----
return(0);
}
//+------------------------------------------------------------------+
//| DPO |
//+------------------------------------------------------------------+
int start()
{
int i, counted_bars=IndicatorCounted();
double t_prd;
//----
if(Bars <= x_prd)
return(0);
//---- initial zero
if(counted_bars < x_prd)
{
for(i = 1; i <= x_prd; i++)
dpo[CountBars-i] = 0.0;
}
//----
i = CountBars - x_prd - 1;
t_prd = x_prd / 2 + 1;
//----
while(i >= 0)
{
dpo[i] = Close[i] - iMA(NULL, 0, x_prd, t_prd, MODE_SMA, PRICE_CLOSE, i);
i--;
}
return(0);
}
//+------------------------------------------------------------------+
All it is basically
DPO(i) = Close(i) - SMA(i, N)
where N is the moving average period.
Thanks!!!
