Hi dear support.

I have a problem with my strategy.

IT opens 1 position,than closes on condition,and opens it in opposing direction.

But when I started to use a breakeven code, I met a problem of imidiately close of my position as it was opened.




This Breakeven code works not only to bring a SL to an opened price but to bring it with some profit pips.
It works fine on a historical tester, but on a DEMO & LIVE trading gives an above mentioned picture,and writes a massage in log:



So please sea part of code:

   // BreakEven
      if(_breakeven!=0) {          
      for (IOrder order : engine.getOrders(instr)) {

           if(order.getOrderCommand()==IEngine.OrderCommand.BUY) {
                if(tick.getBid()-order.getOpenPrice()>=_breakeven*instr.getPipValue()) {
                      if(round(order.getOpenPrice()+_breakeven_pips*instr.getPipValue(),5)>order.getStopLossPrice()) order.setStopLossPrice(round(order.getOpenPrice()+_breakeven_pips*instr.getPipValue(),5));
                }
           }  
           
           if(order.getOrderCommand()==IEngine.OrderCommand.SELL) {
               
               if(order.getOpenPrice()-tick.getAsk()>=_breakeven*instr.getPipValue()) {                   
                      if(round(order.getOpenPrice()-_breakeven_pips*instr.getPipValue(),5)<order.getStopLossPrice()) order.setStopLossPrice(round(order.getOpenPrice()-_breakeven_pips*instr.getPipValue(),5));                      
               }
           }         

      }      
      }   

What is wrong?

Please give advice.
Your faithfully,
Illya Budayev

Please, provide the strategy that replicates the case. If you don't want to post it on forum, you can send it to [email protected]

Sent you an email. Pls confirm if you got received.

We have received your email and will answer as soon as possible.

please...

//class variable
    private boolean breakEvenReached = false;

    //method
    private void updateBreakEven(IOrder order, double breakEvenPips, double breakEvenTriggerPips) throws JFException {

        if (breakEvenReached == false && order.getProfitLossInPips() >= breakEvenTriggerPips) {

            double breakEvenPrice = getPriceWithAddedPips(order.getInstrument(), order.getOpenPrice(),
                                                          order.isLong() ? breakEvenPips : -breakEvenPips);

            order.setStopLossPrice(breakEvenPrice);
            breakEvenReached = true;

        }

    }

    //helper
    private double getPriceWithAddedPips(Instrument instrument, double price, double pipsToAdd) {
        if (instrument == null) {

            return 0.0D;
        }
        return getRoundedDouble(price + (instrument.getPipValue() * pipsToAdd), instrument.getPipScale() + 1);
    }

    private double getRoundedDouble(double value, int precision) {
        double roundingFactor = Math.pow(10, precision);
        return Math.round(value * roundingFactor) / roundingFactor;
    }

We were unable to reproduce this problem. For us the strategy is setting break even orders correctly.
Does it occur in DEMO or LIVE, does it repeat in historical tester. What parameters did you use to call the strategy?
Also it would be great if you could give a simplified strategy code that would reproduce the problem.

The code what I sent to you is original. I tried it on a historical tester, and it gives a predicted result, it works out. But when I try it on a DEMO account in remote and local mode,it shows an above mentioned picture. What I exactly see, my strategy opens a position then in a 1-2 seconds it changed a STOP LOSS and bring it higher than a open price if its BUY position, but some times it gives a correct stop loss if position is SELL. So it looks like a problem with a stop loss. This situation appeared if _breakeven and _breakeven_pips parameters are more than 0.

What are the parameters that are being used to run the strategy?

Hi! Sorry for a long delay . I was bussy with a contests.

So , here they are my parameterse that I use, for checking my strategy on a DEMO remote and local run, both of them give same above mantion result : that in a time as it open a postion a strategy bring a stop loss above the open price ,if it BUY position, or it bring lower . So my position as well closes.

 @Configurable("Instrument:") public Instrument instr = Instrument.EURUSD;
    @Configurable(value="Period:") public Period per = Period.TEN_SECS;
    @Configurable(value="TE Time Period:", stepSize=1) public int TEtimePeriod = 19;
    @Configurable(value="TE Deviation:", stepSize=0.01) public double TEdeviation = 0.05;
    public double amount = 0.01;
    @Configurable(value="Take Profit:", stepSize=0.1) public double tp = 100;
    @Configurable(value="Stop Loss:", stepSize=0.1) public double sl = 200;
    @Configurable("Risk in %") public double lots = 25;
    @Configurable("Breakeven") public int _breakeven=5;    
    @Configurable("Breakeven pips") public int _breakeven_pips=2;  

So a same picture appeared.

But I changed my code , thanks to MR.nicejack . Danke )

It almost works.
But new problem appear,

17:54:50 java.lang.NullPointerException @ TE_BreakEven_2.onBar(TE_BreakEven_2.java:207)

As I got, this problem is connected with this line

 double breakEvenPrice = getPriceWithAddedPips(order.getInstrument(), order.getOpenPrice(),
                                                          order.isLong() ? breakEvenPips : -breakEvenPips);

if I make last line parameter breakEvenPips positive and it looks like this

order.isLong() ? breakEvenPips : breakEvenPips

a NullPointerException dissappear but a breakeven works only in one way.

A common solution could be to print out variable values to see which of them is null.

Got it. At last I did it, by the example from dukascopy wiki paragraph named Break even for multiple orders

and with a big thanks to MR.nicejack .

I got a code that has this view:

 

//CLASS

    private List<IOrder> myOrders = new ArrayList<IOrder>();
    private IOrder order;


public void onTick(Instrument instrument, ITick tick) throws JFException {
// BreakEven
      
          if(instrument != this.instr 
            || myOrders.isEmpty() //all BE's reached, nothing to check
            
        ){
         return ;
        }
       List<IOrder> ordersBeReached = new ArrayList<IOrder>();
    for(IOrder order  : myOrders){
          if( order.getProfitLossInPips() >= _breakeven ){                  
       
             double breakEvenPrice = getPriceWithAddedPips(order.getInstrument(), order.getOpenPrice(),order.isLong() ? _breakeven_pips : -_breakeven_pips);
             order.setStopLossPrice(breakEvenPrice);
             ordersBeReached.add(order);            
            console.getOut().println("breakEvenReached");     
          }
    }
           for(IOrder order  : ordersBeReached){
        myOrders.remove(order);
    }
         }

Tnank you very much